On Mon, Jan 08, 2018 at 08:28:45AM -0800, Ben Pfaff wrote: > On Mon, Jan 08, 2018 at 11:55:26AM +0000, Weglicki, MichalX wrote: > > Hi Ben, > > > I don't like the idea implied in the code in a few places that name[] in > > > struct netdev_custom_counter might not be null-terminated. I think that > > > we should ensure that it is always null terminated. Otherwise there is > > > a pitfall for carelessly written code. > > To be honest I'm not sure what I could do here, each time statistics are > > Requested from netdev, whole buffer is set to "0", so even it > > Particular netdev implementation would return string which > > Is not null-terminated, it will be as all other characters in > > counter name field, will be "\0". When message is decoded from > > open flow buffer, proper check is done, so this part of the code is safe. > > If there is anything else you would like me to do, just let me know. > > Maybe I misinterpreted some code. I'll take another look. > > Thanks for v3!
Actually, could you respond to Kevin Traynor first? https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/342747.html _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
