> On Dec 28, 2017, at 4:13 PM, Gregory Rose <[email protected]> wrote: > >> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c >> index 3bdd64d4d552..ec92c6a730bf 100644 >> --- a/ofproto/ofproto-dpif-xlate.c >> +++ b/ofproto/ofproto-dpif-xlate.c >> @@ -2927,7 +2927,13 @@ compose_sflow_action(struct xlate_ctx *ctx) >> return 0; >> } >> - union user_action_cookie cookie = { .type = USER_ACTION_COOKIE_SFLOW }; >> + union user_action_cookie cookie = { >> + .sflow = { >> + .header.type = USER_ACTION_COOKIE_SFLOW, >> + .header.ofp_in_port = ctx->xin->flow.in_port.ofp_port, >> + .header.ofproto_uuid = ctx->xbridge->ofproto->uuid >> + } >> + }; > > I don't know how old of a compiler we're supposed to support but this breaks > the 4.8.4 compiler > that comes with the Ubuntu 14.04 distro when warnings are treated as errors.
Based on Ben's suggestions, I ended up removing these nested structs. I was able to build cleanly on a 4.8.5 compiler on Ubuntu 16.04. Let me know if you still see breakage in v2. Thanks, --Justin _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
