Hi Alin, thanks for the review. I personally feel we should be consistent and run configure, and have a single make command to build both user space and kernel. What part did you find complicated?
Thanks, Shashank ________________________________________ From: [email protected] <[email protected]> Sent: Thursday, February 8, 2018 9:32:59 AM To: Shashank Ram; [email protected] Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets It looks a bit complicated. What do you think about the following approach: git diff datapath-windows/automake.mk diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 3820041f6..164567734 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@ -85,6 +85,26 @@ EXTRA_DIST += \ datapath-windows/ovsext/precompsrc.c \ datapath-windows/ovsext/resource.h +ARCH=x64 + datapath_windows_analyze: all - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Analyze" - MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Analyze" + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Analyze" //p:Platform=$(ARCH) + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Analyze" //p:Platform=$(ARCH) + +datapath_windows_win_8_debug: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Debug" //p:Platform=$(ARCH) + +datapath_windows_win_8_release: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8Release" //p:Platform=$(ARCH) + +datapath_windows_win_8_1_debug: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Debug" //p:Platform=$(ARCH) + +datapath_windows_win_8_1_release: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win8.1Release" //p:Platform=$(ARCH) + +datapath_windows_win_10_debug: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win10Debug" //p:Platform=$(ARCH) + +datapath_windows_win_10_release: all + MSBuild.exe //nologo //maxcpucount datapath-windows/ovsext.sln /target:Build /property:Configuration="Win10Release" //p:Platform=$(ARCH) ./boot.sh; ./configure CC=./build-aux/cccl LD="$(which link)" LIBS="-lws2_32 -liphlpapi -lwbemuuid -lole32 -loleaut32" --prefix="C:/openvswitch/usr" --localstatedir="C:/openvswitch/var" --sysconfdir="C:/openvswitch/etc" --with-pthread="C:/pthread"; make clean && make -j6; make datapath_windows_win_8_debug datapath_windows_win_8_release datapath_windows_win_8_1_debug datapath_windows_win_8_1_release datapath_windows_win_10_debug datapath_windows_win_10_release On the plus side you don't need to rerun the configure when you want to change things. As another plus size you just pass in the parameters for the userspace and compile the Debug/release version which the user prefers. Thanks, Alin. -----Mesaj original----- De la: [email protected] [mailto:[email protected]] În numele Shashank Ram Trimis: Tuesday, February 6, 2018 11:30 PM Către: [email protected] Subiect: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets Adds support to selectively compile kernel driver for target versions. This is useful when environments to compile for all targets might not be available on the user's machine, or if the user wants to only compile some targets selectively. Also once appveyor has support to build Win10 targets, we will not pass the "--with-vstudiotargetver" to the configure script. Signed-off-by: Shashank Ram <[email protected]> --- _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
