Trimming the message a bit. -----Mesaj original----- De la: [email protected] [mailto:[email protected]] În numele Shashank Ram Trimis: Thursday, February 8, 2018 7:50 PM Către: [email protected]; [email protected] Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets
Hi Alin, thanks for the review. I personally feel we should be consistent and run configure, and have a single make command to build both user space and kernel. What part did you find complicated? [Alin Serdean] I.e. if I configure to target 8. And after I need to target 10 I need to do a reconfigure (similar, for debug and or other platforms). The configure part is particularly slow on Windows. For convenience the old part with selecting Debug/Release and trying to build for all the compilers found in the system is still there, so building both userspace and kernel will still be in a single command. I don't see a huge issue to specify two or more make commands to build a particular target of the kernel via the shell. Thanks, Shashank ________________________________________ From: [email protected] <[email protected]> Sent: Thursday, February 8, 2018 9:32:59 AM To: Shashank Ram; [email protected] Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets It looks a bit complicated. What do you think about the following approach: git diff datapath-windows/automake.mk diff --git a/datapath-windows/automake.mk b/datapath-windows/automake.mk index 3820041f6..164567734 100644 --- a/datapath-windows/automake.mk +++ b/datapath-windows/automake.mk @@ -85,6 +85,26 @@ EXTRA_DIST += \ datapath-windows/ovsext/precompsrc.c \ datapath-windows/ovsext/resource.h _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
