Hi, My thoughts are with Shashank on this, it makes sense to have 1 configure and 1 make command to build a particular target, instead of having flexibility to specify multiple targets.
Thanks, Anand Kumar On 2/8/18, 10:56 AM, "[email protected] on behalf of Shashank Ram" <[email protected] on behalf of [email protected]> wrote: ________________________________________ From: [email protected] <[email protected]> Sent: Thursday, February 8, 2018 10:43 AM To: Shashank Ram; [email protected]; [email protected] Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets Trimming the message a bit. -----Mesaj original----- De la: [email protected] [mailto:[email protected]] În numele Shashank Ram Trimis: Thursday, February 8, 2018 7:50 PM Către: [email protected]; [email protected] Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets Hi Alin, thanks for the review. I personally feel we should be consistent and run configure, and have a single make command to build both user space and kernel. What part did you find complicated? [Alin Serdean] I.e. if I configure to target 8. And after I need to target 10 I need to do a reconfigure (similar, for debug and or other platforms). [SR]: In an automated environment, this shouldn't happen. For local compilation, you should be able to manually compile the kernel. The configure part is particularly slow on Windows. For convenience the old part with selecting Debug/Release and trying to build for all the compilers found in the system is still there, so building both userspace and kernel will still be in a single command. I don't see a huge issue to specify two or more make commands to build a particular target of the kernel via the shell. [SR]: I don't think its a big deal either, but its more convenient to run 1 configure and 1 make command. I prefer to keep this as is for now and wait for more reviews. _______________________________________________ dev mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIFBA&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-nAOpE7LIHSPV8uy5-437agMXvkeHHMkR8Us&m=fKK6KZRD0tZEfwHzLhMsabCH5aXzzYiRP-pJR20Xj9o&s=nEl_7Q-LhJ74AdsiY85DjA-kWy0uESr5DyFrWDQYKjs&e= _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
