On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick <[email protected]> wrote:
>
> From: Flavio Leitner <[email protected]>
>
> Add a new command to show the offloading features of
> each data path port.
>
> Signed-off-by: Flavio Leitner <[email protected]>
> Co-authored-by: Mike Pattrick <[email protected]>
> Signed-off-by: Mike Pattrick <[email protected]>

Reviewed-by: David Marchand <[email protected]>

> ---
>  lib/dpif-netdev-unixctl.man |  5 ++++
>  lib/dpif-netdev.c           | 58 +++++++++++++++++++++++++++++++++++++
>  lib/netdev-provider.h       |  3 ++
>  lib/netdev.c                | 35 ++++++++++++++++++++++
>  tests/dpif-netdev.at        | 21 ++++++++++++++
>  5 files changed, 122 insertions(+)
>
> diff --git a/lib/dpif-netdev-unixctl.man b/lib/dpif-netdev-unixctl.man
> index 8cd847416..a1bdb2f9a 100644
> --- a/lib/dpif-netdev-unixctl.man
> +++ b/lib/dpif-netdev-unixctl.man
> @@ -262,3 +262,8 @@ PMDs in the case where no value is specified.  By default 
> "scalar" is used.
>  \fIstudy_cnt\fR defaults to 128 and indicates the number of packets that the
>  "study" miniflow implementation must parse before choosing an optimal
>  implementation.

Nit: other command descriptions are separated with a '.'.
Though, to be fair I don't think it is necessary: the generated manual
looks good to me without it.


> +.IP "\fBdpif-netdev/offload-show\fR [\fIdp\fR] [\fInetdev\fR]"
> +Prints the hardware offloading features enabled in netdev \fInetdev\fR
> +attached to datapath \fIdp\fR. The datapath \fIdp\fR parameter can be
> +omitted if there is only one. All netdev ports are printed if the
> +parameter \fInetdev\fR is omitted.


-- 
David Marchand

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to