On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick <[email protected]> wrote:
> diff --git a/lib/netdev.c b/lib/netdev.c
> index b222a5e64..ad9081f28 100644
> --- a/lib/netdev.c
> +++ b/lib/netdev.c
[snip]
> @@ -966,11 +946,10 @@ netdev_push_header(const struct netdev *netdev,
> size_t i, size = dp_packet_batch_size(batch);
>
> DP_PACKET_BATCH_REFILL_FOR_EACH (i, size, packet, batch) {
> - if (OVS_UNLIKELY(dp_packet_ol_tcp_seg(packet)
> - || dp_packet_ol_l4_mask(packet))) {
> + if (OVS_UNLIKELY(dp_packet_ol_tcp_seg(packet))) {
> COVERAGE_INC(netdev_push_header_drops);
> dp_packet_delete(packet);
> - VLOG_WARN_RL(&rl, "%s: Tunneling packets with HW offload flags
> is "
> + VLOG_WARN_RL(&rl, "%s: Tunneling packets with TSO offloading is "
> "not supported: packet dropped",
> netdev_get_name(netdev));
> } else {
After this block we handle ipv4 checksum "resolution" (from patch 10).
Since this patch now accepts l4 offloads + encapsulation, I think we
need to resolve l4 checksum offloads, here, by calling
dp_packet_ol_send_prepare(packet, 0);.
Or am I missing something else in the code?
--
David Marchand
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
