On Wed, Jul 6, 2022 at 5:34 PM Mike Pattrick <m...@redhat.com> wrote:
> > > Having to touch the packet data this late is scary, but I don't know a
> > > better place for now.
> >
> > We can move it to dp_netdev_upcall which only affects the userspace
> > datapath.
> > Then the upcall handling code gets "complete" packet data, the same as
> > when it gets invoked in the kernel datapath case.
> >
>
> I think this solution also works; if it's preferred stylistically then
> I will make the change for the v5.
>
> Regarding the other comments, I generally agree with the areas you
> identified for refactor but think that it would fit best as a later
> patch. A lot of this code is modified throughout the patchset, so
> applying it now would be difficult.
>
> I propose the next version including:
>
> - conntrack comment
> - { on newline
> - reset dpdk ol_flags
> - relocating dp_packet_ol_send_prepare
>
> And the remaining changes to be added later.
>
> LMKWYT
Ok for me.
Thanks Mike.
--
David Marchand
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
