On 15 Jul 2022, at 12:16, Emma Finn wrote:
> This patchset introduces actions infrastructure changes which allows > the user to choose between different action implementations based on > CPU ISA by using different commands. The infrastructure also > provides a way to check the correctness of the ISA optimized action > version against the scalar version. > This series also introduces optimized versions of the following > actions: > - push_vlan > - pop_vlan > - set_masked eth > - set_masked ipv4 > Below is a table indicating some relative performance benefits for > these actions. > +-----------------------------------------------+-------------------+-----------------+ > | Actions | Scalar with series|AVX with > series | > +-----------------------------------------------+-------------------+-----------------+ > | mod_dl_dst | 1.01x |1.13x > | > +-----------------------------------------------+-------------------+-----------------+ > | push_vlan | 1.01x |1.10x > | > +-----------------------------------------------+-------------------+-----------------+ > | strip_vlan | 1.01x |1.11x > | > +-----------------------------------------------+-------------------+-----------------+ > | mod_ipv4 1 x field | 1.01x |1.02x > | > +-----------------------------------------------+-------------------+-----------------+ > | mod_ipv4 4 x fields | 1.01x |1.21x > | > +-----------------------------------------------+-------------------+-----------------+ > | strip_vlan + mod_dl_dst + mod_ipv4 4 x fields | 1.01x |1.36x > | > +-----------------------------------------------+-------------------+-----------------+ Hi Emma/Harry, I’ve concluded my testing on v10/v11 and found no issues. I also ran some quick tests on v12. However, I did not run any performance tests. Did you guys and/or girl do this on v12? If not, it would be nice to do and report the numbers upstream. Requesting as there are some larger changes since you added the perf numbers to the cover letter. So for the series; Acked-by: Eelco Chaudron <[email protected]> Cheers, Eelco _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
