On 18 Jul 2022, at 14:49, Finn, Emma wrote:
>> -----Original Message-----
>> From: Eelco Chaudron <echau...@redhat.com>
>> Sent: Monday 18 July 2022 10:41
>> To: Stokes, Ian <ian.sto...@intel.com>; Finn, Emma <emma.f...@intel.com>
>> Cc: d...@openvswitch.org; Van Haaren, Harry <harry.van.haa...@intel.com>;
>> Amber, Kumar <kumar.am...@intel.com>; i.maxim...@ovn.org
>> Subject: Re: [v12 00/10] Actions Infrastructure + Optimizations
>>
>>
>>
>> On 15 Jul 2022, at 13:39, Stokes, Ian wrote:
>>
> <SNIP>
>
>>>> This series also introduces optimized versions of the following
>>>> actions:
>>>> - push_vlan
>>>> - pop_vlan
>>>> - set_masked eth
>>>> - set_masked ipv4
>>>> Below is a table indicating some relative performance benefits for
>>>> these actions.
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | Actions | Scalar with series|AVX
>>>> with series |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | mod_dl_dst | 1.01x |1.13x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | push_vlan | 1.01x |1.10x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | strip_vlan | 1.01x |1.11x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | mod_ipv4 1 x field | 1.01x |1.02x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | mod_ipv4 4 x fields | 1.01x |1.21x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>> | strip_vlan + mod_dl_dst + mod_ipv4 4 x fields | 1.01x |1.36x
>>>> |
>>>> +-----------------------------------------------+-------------------+-----------------+
>>>>
>>>
>>> Thanks all for the work/reviews on this, given that it has been under
>> discussion prior to the soft freeze I have merged this to master.
>>
>> Thanks, still would like some answers on the performance numbers.
>>
> <SNIP>
>
> Hi Eelco,
>
> These performance numbers were updated on the cover letter for the v8 of this
> series as this was when some changes were made to the AVX code.
> I didn't re run on v9/10/11/12.
> However, I just re ran on the v12 and checked a few of actions (mod_dl_dst,
> strip_vlan, mod_ipv4 4 x fields, strip_vlan + mod_dl_dst + mod_ipv4 4 x
> fields), and compared with the v8 data to ensure consistency.
> Performance results are < 1% delta from the v8 posted data.
Thanks Emma for the update on the performance numbers. So < 1% sounds good to
me.
//Eelco
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev