On 10 Dec 2022, at 3:16, Ilya Maximets wrote:
> This patch set allows OVS to build with libxdp and newer libbpf. > It also enables AF_XDP support by default as long as all the > dependencies are available. Hi Ilya, I did not yet review the patch, but I do not like enabling AF_XPD support by default for the following reasons: - I still believe AF_XDP support in OVS has not had many field trials, so I would still classify this as an “experimental” feature. - Reversing build option logic might cause problems for distributions (or at least require people to think, as now they have to explicitly disable it). - I can remember there were some (memory management) issues/limitations, which William was supposed to send patches for, but never did. Cheers, Eelco > Ilya Maximets (6): > ci: Fix overriding OPTS provided from the yml. > netdev-afxdp: Allow building with libxdp and newer libbpf. > acinclude.m4: Build with AF_XDP support by default if possible. > github: Test AF_XDP build using libbpf instead of kernel sources. > Documentation/afxdp: Use packaged libbpf/libxdp for the build. > rhel: Enable AF_XDP by default in Fedora builds. > > .ci/linux-build.sh | 24 +------ > .github/workflows/build-and-test.yml | 9 +-- > Documentation/intro/install/afxdp.rst | 43 ++++-------- > NEWS | 5 ++ > acinclude.m4 | 94 ++++++++++++++++++--------- > debian/rules | 8 ++- > lib/automake.mk | 1 - > lib/libopenvswitch.pc.in | 2 +- > lib/netdev-afxdp-pool.c | 2 + > lib/netdev-afxdp-pool.h | 5 -- > lib/netdev-afxdp.c | 38 ++++++++--- > rhel/openvswitch-fedora.spec.in | 8 ++- > 12 files changed, 128 insertions(+), 111 deletions(-) > > -- > 2.38.1 _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
