Ilya Maximets <[email protected]> writes: > On 2/14/23 14:54, Eelco Chaudron wrote: >> Run "make check-offloads" as part of the GitHub actions tests. >> >> This test was run 25 times using GitHub actions, and the >> failing rerun test cases where excluded. There are quite some >> first-run failures, but unfortunately, there is no other >> more stable kernel available as a GitHub-hosted runner. >> >> Signed-off-by: Eelco Chaudron <[email protected]> >> --- > > It doesn't seems to take that much time. Maybe it's not that > bad of an idea after all. :) > > It might make sense to run this job with asan/ubsan enabled. > What do you think? We might re-structure asan/ubsan jobs to > run them at the same time for this, like OVN does. > >> .ci/linux-build.sh | 6 +++++- >> .github/workflows/build-and-test.yml | 8 +++++++- >> 2 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh >> index 10021fddb..cafff4d83 100755 >> --- a/.ci/linux-build.sh >> +++ b/.ci/linux-build.sh >> @@ -163,7 +163,7 @@ fi >> >> OPTS="${EXTRA_OPTS} ${OPTS} $*" >> >> -if [ "$TESTSUITE" ]; then >> +if [ "$TESTSUITE" = 'test' ]; then >> # 'distcheck' will reconfigure with required options. >> # Now we only need to prepare the Makefile without sparse-wrapped CC. >> configure_ovs >> @@ -173,6 +173,10 @@ if [ "$TESTSUITE" ]; then >> TESTSUITEFLAGS=-j4 RECHECK=yes >> else >> build_ovs >> + if [ -n "$TESTSUITE" ]; then >> + sudo -E PATH="$PATH" make "$TESTSUITE" TESTSUITEFLAGS="$TEST_OPTS" \ >> + RECHECK=yes >> + fi >> fi >> >> exit 0 >> diff --git a/.github/workflows/build-and-test.yml >> b/.github/workflows/build-and-test.yml >> index 82675b973..4020f0882 100644 >> --- a/.github/workflows/build-and-test.yml >> +++ b/.github/workflows/build-and-test.yml >> @@ -18,9 +18,10 @@ jobs: >> M32: ${{ matrix.m32 }} >> OPTS: ${{ matrix.opts }} >> TESTSUITE: ${{ matrix.testsuite }} >> + TEST_OPTS: ${{ matrix.test_opts }} >> >> name: linux ${{ join(matrix.*, ' ') }} >> - runs-on: ubuntu-20.04 >> + runs-on: ubuntu-22.04 >> timeout-minutes: 30 >> >> strategy: >> @@ -90,6 +91,10 @@ jobs: >> m32: m32 >> opts: --disable-ssl >> >> + - compiler: gcc >> + testsuite: check-offloads >> + test_opts: "-k !'offloads - check interface meter >> offloading',!'offloads - check_pkt_len action',!'conntrack - force >> commit',!'conntrack - Multiple ICMP traverse'" > > This doesn't look pretty, especially in the job name. Maybe we can > add a special keyword like "AT_KEYWORDS([github_skip])" and have > "!github_skip" here instead?
I agree, this doesn't look nice. Actually, I think with TESTSUITEFLAGS="--list" we can see the keywords associated as well, so it would be possible to see which tests are included as well. If we do choose something like this, it should be put in the documentation clearly that we have such a skip keyword, and such option should be used sparingly. > Meter offload failures still look like a bug to me though. > >> + >> steps: >> - name: checkout >> uses: actions/checkout@v3 >> @@ -152,6 +157,7 @@ jobs: >> mkdir logs >> cp config.log ./logs/ >> cp -r ./*/_build/sub/tests/testsuite.* ./logs/ || true >> + cp -r ./*/_build/sub/tests/system-offloads-testsuite.* ./logs/ || >> true >> tar -czvf logs.tgz logs/ >> >> - name: upload logs on failure _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
