On 24/05/2023 16:05, Robin Jarry wrote:
Kevin Traynor, May 24, 2023 at 16:54:
The "rss" item should be mandatory anyway. There should be no way to
disable it. I assume that it is what Ilya meant with these "+" symbols.
That would leave us with these examples:
# lacp+bfd on separate queue, rss on other queues
options:rx-steering=rss,lacp,bfd
# same
options:rx-steering=lacp,bfd,rss
^ It looks a little odd to me that some values are for single queues and
some are for the rest of the queues, with no way to distinguish.
So maybe Ilya had placed significance in the order with his suggestion ?
i.e. [default]+[single queue proto]+[other single queue proto]+...
I don't want to bike shed too much on it, i guess with good docs, it can
be clear anyway.
# only regular rss, same as no config at all
options:rx-steering=rss
# invalid configurations
options:rx-steering=lacp
options:rx-steering=
(^ This will be ok and use the default rss)
In that case, maybe we should exclude "rss" from the available items to
avoid confusion and only require users to specify the protocols that
need to be put in a separate queue. The remaining queues being rss by
default.
Would that be ok?
Ilya explained the reasoning behind his idea in other mail and it seems
fine, so for the sake of progress, I'd say to go with with his idea if
you don't object to it.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
