On 24/05/2023 11:41, Ilya Maximets wrote:
On 5/24/23 09:18, Robin Jarry wrote:
Ilya Maximets, May 23, 2023 at 22:04:
'rxq-isolate' will be confused with 'other_config:pmd-rxq-isolate'.
Same likely goes for the 'isolated-rxq'.
'rxq-steernig' may be confused with 'other_config:tx-steering'.
But this can be argued that it's essentially similar functionality,
so should be named similarly. Maybe we can double down on that and
use options:rx-steernig=rss|rss+lacp|... with 'rss' being a default
configuration?
I like that idea. Instead of "rss", how about "hash" to match what
tx-steering is using?
I'm not sure if it's better to use 'rss' or 'hash' in this context.
Aaron, Kevin, what do you think?
Hmm, not sure on this one. I have a feeling that having a 'hash' mode
for tx-steering that only applies to vhost devices, and 'hash' mode for
rx-steering that only applies to NICs means people will miss the
subtlety and try to enable the wrong hash mode on the wrong device :-)
So 'rss' might make it more distinct.
So the value of options:rx-steering would be "hash" followed by an
arbitrary list of preset protocols (for now, only "lacp") all separated
by "+". It may also open the door for other base steering methods than
"hash" ("rr" for round-robin some day?).
If that is OK, I can prepare a v11 with everything renamed.
Any reason for '+' ? I think commas are used more frequently. If it
needed to be extended in future for some extra config, then adding
'key:value' pairs would be seamlessly. e.g.
=rss:<reta size?>, lacp:<num of queues?>
Might make sense for the code review. Kevin was looking at the
patch, IIUC.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
