On 6/22/23 15:37, Aaron Conole wrote: > Dumitru Ceara <[email protected]> writes: > >> On 6/22/23 13:56, Aaron Conole wrote: >>> Dumitru Ceara <[email protected]> writes: >>> >>>> This avoids manual intervention when upstream ovn-kubernetes changes >>>> its dependency versions. >>>> >>>> Signed-off-by: Patryk Diak <[email protected]> >>>> Co-authored-by: Patryk Diak <[email protected]> >>>> Signed-off-by: Dumitru Ceara <[email protected]> >>>> --- >>> >>> LGTM overall. It's also the only patch to have successfully built >>> recently, so I assume it will be important to apply for other patches to >>> succeed. >>> >> >> Thanks for the review! Yes, all other patches were failing ovn-kube CI >> when building the container image, effectively keeping us in the dark >> wrt effects on ovn-kubernetes. >> >>>> .ci/ovn-kubernetes/Dockerfile | 16 +++++++------- >>>> .ci/ovn-kubernetes/prepare.sh | 11 ++++++++++ >>>> .github/workflows/ovn-kubernetes.yml | 31 +++++++++++++++++----------- >>> >>> We got some warnings on this file due to line lengths. Maybe we should >>> exclude yml from the line length check. WDYT? >>> >> >> Sure, I can post a patch for that. Should I prepare a patch for OVS >> though? We normally try to keep our checkpatch version in sync with the >> OVS one. > > Please do :) Then they can just be sync'd after, I guess. >
Done: https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ Thanks! _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
