On 10/20/23 18:25, Mark Michelson wrote:
> The "IPv6 ND Router Solicitation responder" test was altered to test
> more cases. When the test was updated, the author updated the test to
> use fmt_pkt instead of constructing the packets by hand. Unfortunately,
> this change did not include the directive to skip the test if scapy is
> not installed. This commit adds the check so that systems that do not
> have scapy installed can still run tests appropriately.
> 
> Fixes: 7b70e07ce ("pinctrl: Reply with correct destination for ICMPv6 RA 
> packets")

The hash should be 12 characters long.

With that addressed:

Acked-by: Ilya Maximets <[email protected]>

> Signed-off-by: Mark Michelson <[email protected]>
> ---
>  tests/ovn.at | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 658711dc9..637d92bed 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -12544,6 +12544,7 @@ AT_CLEANUP
>  
>  OVN_FOR_EACH_NORTHD([
>  AT_SETUP([IPv6 ND Router Solicitation responder])
> +AT_SKIP_IF([test $HAVE_SCAPY = no])
>  AT_KEYWORDS([ovn-nd_ra])
>  ovn_start
>  

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to