On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson <[email protected]> wrote:
> The "IPv6 ND Router Solicitation responder" test was altered to test
> more cases. When the test was updated, the author updated the test to
> use fmt_pkt instead of constructing the packets by hand. Unfortunately,
> this change did not include the directive to skip the test if scapy is
> not installed. This commit adds the check so that systems that do not
> have scapy installed can still run tests appropriately.
>
I'll bite...
Why shouldn't we expect scapy installed during a test suite run? I'd post a
patch to remove HAVE_SCAPY and install scapy package in all CI jobs, but
before I do, is there anything that makes it a bad idea?
>
> Fixes: 7b70e07ce ("pinctrl: Reply with correct destination for ICMPv6 RA
> packets")
> Signed-off-by: Mark Michelson <[email protected]>
> ---
> tests/ovn.at | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/ovn.at b/tests/ovn.at
> index 658711dc9..637d92bed 100644
> --- a/tests/ovn.at
> +++ b/tests/ovn.at
> @@ -12544,6 +12544,7 @@ AT_CLEANUP
>
> OVN_FOR_EACH_NORTHD([
> AT_SETUP([IPv6 ND Router Solicitation responder])
> +AT_SKIP_IF([test $HAVE_SCAPY = no])
> AT_KEYWORDS([ovn-nd_ra])
> ovn_start
>
> --
> 2.40.1
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
