On Fri, Oct 20, 2023 at 5:42 PM Ilya Maximets <[email protected]> wrote:
> On 10/20/23 21:43, Ihar Hrachyshka wrote: > > On Fri, Oct 20, 2023 at 12:26 PM Mark Michelson <[email protected]> > wrote: > > > >> The "IPv6 ND Router Solicitation responder" test was altered to test > >> more cases. When the test was updated, the author updated the test to > >> use fmt_pkt instead of constructing the packets by hand. Unfortunately, > >> this change did not include the directive to skip the test if scapy is > >> not installed. This commit adds the check so that systems that do not > >> have scapy installed can still run tests appropriately. > >> > > > > I'll bite... > > > > Why shouldn't we expect scapy installed during a test suite run? I'd > post a > > patch to remove HAVE_SCAPY and install scapy package in all CI jobs, > > I think, it is already installed in our CI... > Ack, I wasn't sure that's the case but I now realize that it's part of ovn-tests image used in CI. Then what I suggest is to require scapy for other environments, e.g. for regular development. (I see that Vagrantfile in tree doesn't list scapy as a dependency, though I don't know if this is an authoritative place to list these.) > > > but > > before I do, is there anything that makes it a bad idea? > > Failed tests should mean "problem with OVN itself". Tests should > not fail due to issues in external tools. We even check for nc > to be installed. > What I'd like to avoid is, specifically, the use of the macro in AT_SKIP_IF. I don't think it's wise to silently skip test cases when one of the test suite dependencies is not installed. Now that you mention `nc`, I now see that we silently skip other tests, for NC and TCPDUMP and OPENSSL and PYTHON etc. I'd suggest that most of these tools can be safely assumed present in the developer environment, and so it would be better if we don't skip them (but perhaps fail early if needed). (And as for openssl, I don't think the OVN test suite can be built without it, since we generate certificate bundles to be used in test clusters as part of `make check`.) > > Best regards, Ilya Maximets. > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
