Re: [ovs-dev] [PATCH 2/6] build-aux/extract-ofp-actions: Fix flake8 and syntax errors.

[Eelco Chaudron]

On 30 Oct 2023, at 21:10, Ilya Maximets wrote:

> A few general style issues like extra spacing and lines being too long.
> Also, unused variables 'error_types' and 'comments'.  And a few invalid
> escape sequences, which are not actual escape sequences, but cause
> actual syntax warnings starting python 3.12 and will eventually become
> syntax errors [1]:
>
>  extract-ofp-actions:122: SyntaxWarning: invalid escape sequence '\['
>   comment = re.sub('\[[^]]*\]', '', comment)
>  extract-ofp-actions:125: SyntaxWarning: invalid escape sequence '\s'
>   m = re.match('([^:]+):\s+(.*)$', comment)
>
> These are fixed by converting to raw strings.
>
> [1] https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences
>
> Signed-off-by: Ilya Maximets <i.maxim...@ovn.org>

Thanks for fixing this, and the changes look good to me.

Acked-by: Eelco Chaudron <echau...@redhat.com>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev