On 30 Oct 2023, at 21:10, Ilya Maximets wrote:
> A few general style issues like extra spacing and line length,
> semicolons at the end of the line and unused variable 'raw_types'.
> And a few invalid escape sequences, which are not actual escape
> sequences, but cause actual syntax warnings starting python 3.12
> and will eventually become syntax errors [1]:
>
> extract-ofp-msgs:118: SyntaxWarning: invalid escape sequence '\s'
> m = re.match('\s+(?:OFPRAW_%s)(\d*)_([A-Z0-9_]+),?$' % type_,
>
> These are fixed by converting to raw strings.
>
> [1] https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences
>
> Signed-off-by: Ilya Maximets <[email protected]>
Thanks for fixing this, and the changes look good to me.
Acked-by: Eelco Chaudron <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
- [ovs-dev] [PATCH 0/6] build-aux: Fix flake8 and syntax iss... Ilya Maximets
- [ovs-dev] [PATCH 1/6] automake: Move build-aux EXTRA_... Ilya Maximets
- Re: [ovs-dev] [PATCH 1/6] automake: Move build-au... Eelco Chaudron
- [ovs-dev] [PATCH 2/6] build-aux/extract-ofp-actions: ... Ilya Maximets
- Re: [ovs-dev] [PATCH 2/6] build-aux/extract-ofp-a... Eelco Chaudron
- [ovs-dev] [PATCH 4/6] build-aux/extract-ofp-fields: F... Ilya Maximets
- Re: [ovs-dev] [PATCH 4/6] build-aux/extract-ofp-f... Eelco Chaudron
- [ovs-dev] [PATCH 5/6] build-aux/extract-ofp-msgs: Fix... Ilya Maximets
- Re: [ovs-dev] [PATCH 5/6] build-aux/extract-ofp-m... Eelco Chaudron
- [ovs-dev] [PATCH 3/6] build-aux/extract-ofp-errors: F... Ilya Maximets
- Re: [ovs-dev] [PATCH 3/6] build-aux/extract-ofp-e... Eelco Chaudron
- [ovs-dev] [PATCH 6/6] build-aux: Enable flake8 checks... Ilya Maximets
- Re: [ovs-dev] [PATCH 6/6] build-aux: Enable flake... Eelco Chaudron
- Re: [ovs-dev] [PATCH 0/6] build-aux: Fix flake8 and s... Ihar Hrachyshka
- Re: [ovs-dev] [PATCH 0/6] build-aux: Fix flake8 a... Ilya Maximets
