+1 for the series. Reviewed-By: Ihar Hrachyshka <[email protected]>
On Mon, Oct 30, 2023 at 4:10 PM Ilya Maximets <[email protected]> wrote: > The main goal of this patch set is to enable builds without warnings > on systems with Python 3.12. Python 3.12 turned having invalid escape > sequences into a SyntaxWarning. In the future it will become an > actual syntax error: > > https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences > > Fix all the instances to avoid these warnings. Adding all the scripts > to a flake8 check to avoid re-introducing the issue. Fixing all the > current flake8 warnings along the way. > > Note: before this patch set the build is not failing even with > --enable-Werror, but the warnings are just printed out during the build. > After this patch set, new warnings will fail the flake8 check and fail > the build. > > Also, I tried to use black to fix these files more or less automatically, > but it makes way too many unnecessary changes, so I decided to just fix > files manually. > > Ilya Maximets (6): > automake: Move build-aux EXTRA_DIST updates to their own file. > build-aux/extract-ofp-actions: Fix flake8 and syntax errors. > build-aux/extract-ofp-errors: Fix flake8 and syntax errors. > build-aux/extract-ofp-fields: Fix flake8 and syntax errors. > build-aux/extract-ofp-msgs: Fix flake8 and syntax errors. > build-aux: Enable flake8 checks for python extraction scripts. > > build-aux/automake.mk | 24 ++++-- > build-aux/extract-ofp-actions | 108 ++++++++++++++++----------- > build-aux/extract-ofp-errors | 101 +++++++++++++++---------- > build-aux/extract-ofp-fields | 50 ++++++------- > build-aux/extract-ofp-msgs | 26 ++++--- > datapath-windows/include/automake.mk | 2 - > include/automake.mk | 1 - > include/openflow/automake.mk | 3 - > lib/automake.mk | 4 - > 9 files changed, 185 insertions(+), 134 deletions(-) > > -- > 2.41.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
