On 28 Feb 2024, at 4:38, Chris Mi wrote: > On 2/28/2024 9:20 AM, Chris Mi via dev wrote: >> On 2/27/2024 6:54 PM, Eelco Chaudron wrote: >>> >>> >>> On 9 Jan 2024, at 11:40, Eelco Chaudron wrote: >>> >>>> On 9 Jan 2024, at 10:22, Chris Mi wrote: >>>> >>>>> Hi Roi and Eelco, >>>>> >>>>> Sorry for the late reply. We are still busy with other task. So maybe >>>>> we'll have to postpone it. >>>> >>>> Thanks for the update and I guess we are too late for the upcoming release >>>> unless you can submit it this week. >>> >>> Now that 3.3 has been released, do you have an idea when you can submit a >>> new revision? This so we have time to review before the next release? >> I'm working on it now. Hopefully I can submit a new revision this week. >> But I can't reproduce the memory leak Ilya found. Not sure if I miss >> anything. Do you have any idea? >> >> Anyway, I found something wrong. Maybe we should introduce >> offload_sample_uninit() to free sample->userspace_actions if something wrong >> happens. > I attached a possible fix, could you please review it?
Hi Chris, I do not have the full context of these series clear anymore, but the fix seems to fix a potential memory leak. I guess Ilya can reply, or we can follow this up in the next revision. //Eelco >> Thanks, >> Chris >> >>> >>>> //Eelco >>>> >>>> FYI, We got an inquiry from Jim Michelson (Nvidia) directly about the >>>> status. >>>> >>>>> Regards, >>>>> Chris >>>>> >>>>> On 1/9/2024 4:52 PM, Roi Dayan wrote: >>>>>> >>>>>> On 02/11/2023 15:24, Eelco Chaudron wrote: >>>>>>> >>>>>>> On 3 Oct 2023, at 17:03, Eelco Chaudron wrote: >>>>>>> >>>>>>>> On 19 Jun 2023, at 12:18, Chris Mi wrote: >>>>>>>> >>>>>>>>> On 6/19/2023 6:04 PM, Eelco Chaudron wrote: >>>>>>>>>> On 19 Jun 2023, at 7:05, Chris Mi wrote: >>>>>>>>>> >>>>>>>>>>> Add three sFlow offload test cases: >>>>>>>>>>> >>>>>>>>>>> 3: offloads - sflow with sampling=1 - offloads enabled ok >>>>>>>>>>> 4: offloads - sflow with sampling=2 - offloads enabled ok >>>>>>>>>>> 5: offloads - ping over vxlan tunnel with sflow - offloads >>>>>>>>>>> enabled ok >>>>>>>>>>> >>>>>>>>>>> Signed-off-by: Chris Mi<c...@nvidia.com> >>>>>>>>>>> Reviewed-by: Roi Dayan<r...@nvidia.com> >>>>>>>>>>> Acked-by: Eelco Chaudron<echau...@redhat.com> >>>>>>>>>> Thanks for making all the suggested changes to this series. This is >>>>>>>>>> my final ack, which should conclude the series :) >>>>>>>>>> >>>>>>>>>> Acked-by: Eelco Chaudron<echau...@redhat.com> >>>>>>>>>> >>>>>>>>>> //Eelco >>>>>>>>>> >>>>>>>>> Sorry for missing your Acked-by for previous patches :( >>>>>>>>> And thanks a lot for acking this patchset. That's so great :) >>>>>>>> Hi Chris, >>>>>>>> >>>>>>>> Any update on this patchset? It has some open questions/comments from >>>>>>>> Ilya, and it would be nice to get the patch in before the next release. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> >>>>>>>> Eelco >>>>>>> Hi Roi, >>>>>>> >>>>>>> As Chris does not seem to reply, do you have any update on this? >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Eelco >>>>>>> >>>>>> Hi Eelco, >>>>>> I don't have an update on this patchset. I'll try to ping Chris about it. >>>>>> >>>>>> Thanks, >>>>>> Roi >>>>>> >>> >> _______________________________________________ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
