On 2/28/24 11:03, Eelco Chaudron wrote: > > > On 28 Feb 2024, at 8:06, Chris Mi wrote: > >> Hi Eelco, >> >> I did a rebase and pushed to github. Nothing changed, but the actions always >> reported the following failure: >> >> -1000 packets transmitted, 1000 received, 0% packet loss, time 0ms >> +744 packets transmitted, 744 received, 0% packet loss, time 0ms >> >> I can't reproduce the failure locally. Not sure if the test machine >> is a little weak. So how about change the test like this to make test robost: >> >> -NS_CHECK_EXEC([at_ns0], [ping -q -c 1000 -i 0.01 -w 12 10.1.1.2 | >> FORMAT_PING], [0], [dnl >> -1000 packets transmitted, 1000 received, 0% packet loss, time 0ms >> +NS_CHECK_EXEC([at_ns0], [ping -q -c 200 -i 0.05 -w 12 10.1.1.2 | >> FORMAT_PING], [0], [dnl >> +200 packets transmitted, 200 received, 0% packet loss, time 0ms > > It looks like the machine might be too slow to handle the 1000 pings in 12 > seconds. Scaling it down should not be a problem. Maybe back to 500, and see > if this is enough?
Is it necessary to send hundreds of packets? Can we just send 3-10 like other tests do? I see, there is an existing test that sends 1000 packets, but it probably should be canged as well. Not as part of this patch set, but in general. In case you missed my previous review for this patch where I pointed out the problem with the slow ping: https://patchwork.ozlabs.org/project/openvswitch/patch/20230619050557.310690-9-...@nvidia.com/#3136718 It should be reproducible locally under ASAN. Ping is not a reliable tool when we're trying to send a particular number of packets, especially with intervals under 100ms. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
