On 27/11/2024 15:31, David Marchand wrote:
> Fixes for Intel drivers are included in DPDK v23.11.2.
> 
> Link: https://git.dpdk.org/dpdk-stable/commit/?id=e8c2cccfbdef
> Link: https://git.dpdk.org/dpdk-stable/commit/?id=1970a0ca45f1
> Link: https://git.dpdk.org/dpdk-stable/commit/?id=80c5c9789b73

> Fixes: 0256ee64ed39 ("dpdk: Use DPDK 23.11.2 release.")

Shouldn't we use the same fixed commit as the one referenced in the
workarounds (6f93d8e62f13 and 29abd07e4fa6) i.e.
Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")

Otherwise LGTM,

Acked-by: Kevin Traynor <[email protected]>

> Signed-off-by: David Marchand <[email protected]>
> ---
>  lib/netdev-dpdk.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index e454a4a5d3..52f2e15fa2 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1353,15 +1353,12 @@ dpdk_eth_dev_init(struct netdev_dpdk *dev)
>          info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_TCP_CKSUM;
>      }
>  
> -    if (!strcmp(info.driver_name, "net_ice")
> -        || !strcmp(info.driver_name, "net_i40e")
> -        || !strcmp(info.driver_name, "net_iavf")
> -        || !strcmp(info.driver_name, "net_txgbe")) {
> +    if (!strcmp(info.driver_name, "net_txgbe")) {
>          /* FIXME: Driver advertises the capability but doesn't seem
>           * to actually support it correctly.  Can remove this once
>           * the driver is fixed on DPDK side. */
>          VLOG_INFO("%s: disabled Tx outer udp checksum offloads for a "
> -                  "net/ice, net/i40e, net/iavf or net/txgbe port.",
> +                  "net/txgbe port.",
>                    netdev_get_name(&dev->up));
>          info.tx_offload_capa &= ~RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
>      }

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to