On 3/6/25 12:20, Dumitru Ceara wrote: > On 3/1/25 2:48 PM, Frank Wagner wrote: >> This patch is the first in a series of patches to make ovn >> buildable on Windows again. >> This patch includes the OVS sources and removes leftovers from the >> original OVS build system. >> >> Signed-off-by: Frank Wagner <frank.wag...@dbosoft.eu> >> >> --- > > Hi Frank, > > Thanks for the patch! > > CC: Ilya and Alin. > > It would be nice if we could enable Windows builds in CI for OVN too. I > know OVS does that. I'd need some help with setting that up though. > > Aside from the fact that it would help reviewers compile-test Windows > changes (I don't really know how to do that for example) it would also > ensure that OVN builds don't break on Windows in the future. > > What do you guys think?
The CI, I think, is necessary if we want to ensure the build will not break in the future. It should be possible to copy what we do in OVS with appveyor or make an equivalent GHA job now that GHA supports windows builds and OVN doesn't really need to build the kernel datapath driver. However, ... It appears that the windows build was broken pretty much after the split, which was many years ago, and there were no complains about that so far. So, I guess, it's pretty safe to say that OVN usage on windows wasn't actually a thing. Also, I'm pretty sure that many OVN features will just not work on Windows due to missing support of certain actions in the windows datapath implementation as well as direct use of some Linux-specific kernel APIs from the ovn-controller. Documentation for the OVN on windows also doesn't really exist, there is a page for it, but it's empty. And OVN doesn't have a way to generate a windows installer package, so the only way to install it is from sources. On OVS side the windows datapath development have stagnated. There are many known issues and the last time a feature was added was in 2022, even though this datapath implementation is missing a lot of features in comparison to others. I'm not sure if it will see a revival or we'll need to deprecate it in the end. Saying that, I think, we should also consider a question if OVN should actually support windows builds in the first place. If the answer is "yes", then we need a proper CI setup and the documentation update on how to install and use it as well as list of features that are not supported. If the answer is "no", then we should remove the remaining broken bits instead. Thoughts? Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
