Hi Noel, Awesome work!
The pull request is huge though, it seems to contain much of the CRS history from 2013… I think it might be based on the wrong branch of spiderlabs/owasp-modsecurity-crs. It should be based off branch "v3.0.0-rc1” so it should only show your own local changes. I think it might be possible to change this in the existing pull request using the Github GUI, but I haven’t ever done this yet, so I’m not sure. If not it might be easier to start over with a new pull request and just re-copy your changed files over. I think I’ll start with a very small pull request today, in order to learn how to do this myself :) Cheers! WH > On 06 Mar 2016, at 16:45, Noël Zindel <m...@noelzindel.org> wrote: > > Hey everyone, > > with Christian backing me, I was able to just bring out the second pull > request for our little project. > As I’m still figuring out all this Git and Github stuff, I’m not quite sure > everything worked as intended. > > https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/298 > <https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/298> > > Can someone please check this out and if OK, I think we are ready to test the > setting. > (I only did a quick configuration check before putting this out, so this > should be tested more thoroughly) > > Thanks. > > Cheers, > Noël > _______________________________________________ > Owasp-modsecurity-core-rule-set mailing list > Owasp-modsecurity-core-rule-set@lists.owasp.org > https://lists.owasp.org/mailman/listinfo/owasp-modsecurity-core-rule-set -- Walter Hop | PGP key: https://lifeforms.nl/pgp
_______________________________________________ Owasp-modsecurity-core-rule-set mailing list Owasp-modsecurity-core-rule-set@lists.owasp.org https://lists.owasp.org/mailman/listinfo/owasp-modsecurity-core-rule-set
