Hi Noël, Thank you for this laborious pull request. I looked at a few of the files and they look good. So we are close AFAICT.
On Sun, Mar 06, 2016 at 04:45:11PM +0100, Noël Zindel wrote: > As I’m still figuring out all this Git and Github stuff, I’m not quite sure > everything worked as intended. Yes, here is the issue. Your pull request goes against the master tree (which is still 2.2.X). The idea is to provide a pull request against v3.0.0-rc1. Did you checkout $> git checkout remotes/upstream/v3.0.0-rc1 before creating your branch? Please save your work (= the updated files) and do a new checkout. Then you import all your files again and then, before you do the pull request, you run a $> git diff The changeset should then show you changes in about 20 files under ./rules. Your pull request #298 has a huge changeset, as it incorporates all the changes of v3.0.0-rc1 against master/2.2.X. Over 100 files... Give it another shot! We're getting there. Ahoj, Christian -- If you're going through hell, keep going. -- Winston Churchill _______________________________________________ Owasp-modsecurity-core-rule-set mailing list Owasp-modsecurity-core-rule-set@lists.owasp.org https://lists.owasp.org/mailman/listinfo/owasp-modsecurity-core-rule-set
