Walter, Christian, thanks for the assistance. I wasn’t quite sure if the 100 commits and 15k lines of changed code in my initial request were just an overall statistic ;)
As it seems, I really only forgot to base my pull request on the 3.0.0-rc1 branch. Unfortunately it’s required to create a new pull request, since there’s no way to adjust the merge target for an existing one. My PR should be fixed now and we’re good to go: https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/300 <https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/300>. And thanks, Walter, for sharing your workflow. Cheers, Noël > On 06 Mar 2016, at 18:43, Walter Hop <mod...@spam.lifeforms.nl> wrote: > > Just in case anyone is interested, this is the procedure I normally follow > for pull requests: > https://gist.github.com/lifeforms/c8778a05bf0385c7f391 > <https://gist.github.com/lifeforms/c8778a05bf0385c7f391> > > I’ve created a pull request here just to test, though Christian may review > and accept it :) I’ll need the file in there so I can easily add to it when > working on the PHP rules. We’ll convert them to use Chaim’s tool when it’s > ready. > https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/299 > <https://github.com/SpiderLabs/owasp-modsecurity-crs/pull/299> > > Cheers! > WH > > -- > Walter Hop | PGP key: https://lifeforms.nl/pgp <https://lifeforms.nl/pgp> > _______________________________________________ > Owasp-modsecurity-core-rule-set mailing list > Owasp-modsecurity-core-rule-set@lists.owasp.org > https://lists.owasp.org/mailman/listinfo/owasp-modsecurity-core-rule-set
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ Owasp-modsecurity-core-rule-set mailing list Owasp-modsecurity-core-rule-set@lists.owasp.org https://lists.owasp.org/mailman/listinfo/owasp-modsecurity-core-rule-set
