bshashikant commented on a change in pull request #551: HDDS-2717. Handle chunk
increments in datanode
URL: https://github.com/apache/hadoop-ozone/pull/551#discussion_r387597641
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -360,20 +360,33 @@ private void watchForCommit(boolean bufferFull) throws
IOException {
}
private CompletableFuture<ContainerProtos.
Review comment:
> The `force` flag is needed to handle the case when the stream is closed
right after a putBlock, without further new data. Since we don't know in
advance which putBlock will be the last, we need to "force" another putBlock in
this case.
If my understanding , if a stream gets closed, as a part of close itself it
should send the last putBlock. Also, we always know which putBlock will be
last, with this putBlock as cumulative length of data written will be higher
and same putBlock future is tracked in futureMap in commitWatcher.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
