bshashikant commented on a change in pull request #551: HDDS-2717. Handle chunk
increments in datanode
URL: https://github.com/apache/hadoop-ozone/pull/551#discussion_r387650192
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -360,20 +360,33 @@ private void watchForCommit(boolean bufferFull) throws
IOException {
}
private CompletableFuture<ContainerProtos.
Review comment:
> > if a stream gets closed, as a part of close itself it should send the
last putBlock
>
> That's happening here.
>
> > we always know which putBlock will be last
>
> This is a stream, caller can write as much data as wanted (within block
size limit). How do we know which will be last before `close()` is called?
What I meant here was a part of close, whatever putBlock request sent will
always be the last. But i get why force flag is being used here. Its the case
where, for example, let's we did a flush first and then did a close without
writing anything in between. In such case, even though no data has been written
in between, a putBlock needs to be enforced. Am i correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
