bshashikant commented on a change in pull request #551: HDDS-2717. Handle chunk
increments in datanode
URL: https://github.com/apache/hadoop-ozone/pull/551#discussion_r387651709
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java
##########
@@ -123,6 +123,12 @@
* */
public static final String OZONE_ADMINISTRATORS_WILDCARD = "*";
+ public static final String OZONE_CLIENT_STREAM_BUFFER_SIZE =
Review comment:
> Ideally the file-per-chunk layout could be improved to use the existing
chunk size config, eg. even if client sends 64KB chunks, server writes 4MB
chunk files.
I like the idea of a new config , but with different config of chunk size
and buffer size can lead to a case where ratis client itself can not send any
request to server if buffer size exceeds chunk size as max message size for
grpc is configured as per chunk size. We can enforce client buffer size <=
chunk size in the code itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
