Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=874105
--- Comment #6 from Mamoru TASAKA <[email protected]> --- For -2.1: * Versioning - Please don't use ".1" for release unless needed. Please use just integer (and %{?dist}) c.f. https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning * Dependency between subpackage. - As said before, usually dependency between subpackage must be _full_ (Epoch)-Version-"Release" and isa specific (i.e. Requires: %{name}%{?_isa} = %{version}-%{release} ) * Directory ownership issue - %{_includedir} itself is already owned by filesystem and should not be owned by qpid-proton-devel. * Enabling test suite - I missed this before, however as the source tarball contains tests/ directory, please do some tests in %check if possible. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qaPuRzaYLP&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
