https://bugzilla.redhat.com/show_bug.cgi?id=991639
--- Comment #4 from efigue <[email protected]> --- (In reply to Christopher Meng from comment #2) > Also, cleanup: > > 1. BuildRoot/Prefix/Vendor tag. We don't use these junk. > > 2. Remove rm -rf %{buildroot} in %install section. > > 3. Remove %defattr(-,root,root) in %files. > > 4. DO NOT use INSTALLED_FILES to list files, please manually write down all. Thanks for the review. I cleaned up RPM spec file: - remove clean section, defattr removed, %define -> %global - remove also rm -rf in install section - not define some macro automatically defined (source, buildroot, release, url) - remove Vendor, Prefix, BuildRoot - remove unwanted .mo file (don't know how to use %search_lang while packaging simultaneously for Python2 qnd Python3.) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=947TH7ZTRu&a=cc_unsubscribe _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
