https://bugzilla.redhat.com/show_bug.cgi?id=1115049
--- Comment #2 from Dominic Cleal <[email protected]> --- (In reply to Florian "der-flo" Lehner from comment #1) > [ ] Please use macros if possible and replace > Source0: > https://github.com/rcrowley/freight/archive/%{commit}/freight-%{commit}.tar. > gz > with > Source0: > https://github.com/rcrowley/%{name}/archive/%{commit}/%{name}-%{commit}.tar. > gz Updated. > [ ] Please add (#1115049) to the inital comment in the spec-file Done, wasn't exactly sure what style this should have, let me know if it should be different. > [ ] Please add LICENSE, NOTES and README.md to the files-section Good catch, updated. > [ ] The Group-fiel is only needed for compatibility with EPEL, so it's > optional I intend to include this in EPEL so have left it in, if that's OK. Thanks very much for the review, the existing URLs have been updated: Spec URL: http://domcleal.fedorapeople.org/reviews/freight/freight.spec SRPM URL: http://domcleal.fedorapeople.org/reviews/freight/freight-0.3.5-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
