https://bugzilla.redhat.com/show_bug.cgi?id=1115049
--- Comment #5 from Florian "der-flo" Lehner <[email protected]> --- (In reply to Dominic Cleal from comment #4) > > [ ] Now you missed to increment the release field for the changes to and > > write a short comment about what have changed. Some kind of: > > > > * Tue Jul 08 2014 Dominic Cleal <[email protected]> 0.3.5-2 > > - Added LICENSE, NOTES and README.md to files-section > > - Added initial tickernumber to initial comment > > > > * Tue Jul 01 2014 Dominic Cleal <[email protected]> 0.3.5-1 > > - Initial version (#1115049) > > Fixed, incremented to -3. You missed, to upload the updated spec-File to http://domcleal.fedorapeople.org/reviews/freight/freight.spec > Is it good practice to import this -3 into Fedora git, or reset it to -1? > (If/when we get there.) It's fine to import -3 into Fedora git. There is no rule to reset it. [ ] You don't need these two lines: mkdir -p %{buildroot}%{_pkgdocdir} install -p -m0644 LICENSE NOTES README.md %{buildroot}%{_pkgdocdir} The %doc LICENSE NOTES README.md in %files is enough. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
