https://bugzilla.redhat.com/show_bug.cgi?id=1115049



--- Comment #6 from Dominic Cleal <dcl...@redhat.com> ---
(In reply to Florian "der-flo" Lehner from comment #5)
> (In reply to Dominic Cleal from comment #4)
> > > [ ] Now you missed to increment the release field for the changes to and
> > > write a short comment about what have changed. Some kind of:
> > > 
> > > * Tue Jul 08 2014 Dominic Cleal <dcl...@redhat.com> 0.3.5-2
> > > - Added LICENSE, NOTES and README.md to files-section
> > > - Added initial tickernumber to initial comment
> > > 
> > > * Tue Jul 01 2014 Dominic Cleal <dcl...@redhat.com> 0.3.5-1
> > > - Initial version (#1115049)
> > 
> > Fixed, incremented to -3.
> 
> You missed, to upload the updated spec-File to
> http://domcleal.fedorapeople.org/reviews/freight/freight.spec

It should be up to date, now -4, please give it a hard refresh.

> [ ] You don't need these two lines:
> mkdir -p %{buildroot}%{_pkgdocdir}
> install -p -m0644 LICENSE NOTES README.md %{buildroot}%{_pkgdocdir}
> 
> The 
> %doc LICENSE NOTES README.md
> in %files is enough.

Ah yes, neat.  Removed and updated.

Spec URL: http://domcleal.fedorapeople.org/reviews/freight/freight.spec
SRPM URL:
http://domcleal.fedorapeople.org/reviews/freight/freight-0.3.5-4.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to