https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Tim Fenn <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([email protected] |
                   |m)                          |



--- Comment #4 from Tim Fenn <[email protected]> ---
(In reply to Antonio Trande from comment #3)
> Hi Tim.
> First of all:
> 
> - Leave a comment about what patches do.
> 

Done.

> - python(2)-sitelib macro is already defined
> 

Removed.

> - Use python2-devel as BR package
> 

Done.

> - Use macros instead of hardlinks:
>   /usr --> %{_prefix}
>   /usr/include/ssm --> %{_includedir}/ssm
> 

Where do you see this in the spec file?

> - 'rm -rf %{buildroot}' and '%defattr(-,root,root,-)' lines are used on
> epel5 only.
> 

Added rhel checks for these lines.

> - doc sub-package isn't noarch
> 

I didn't specify it as such?

> - COPYING is not tagged with %license

Fixed.

New files:

spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to