https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #7 from Antonio Trande <anto.tra...@gmail.com> ---
(In reply to Tim Fenn from comment #6)
> (In reply to Antonio Trande from comment #5)
> > (In reply to Tim Fenn from comment #4)
> > > 
> > > > - doc sub-package isn't noarch
> > > > 
> > > 
> > > I didn't specify it as such?
> > 
> > I don't see any 'BuildArch: noarch' line...
> > 
> 
> OK I'll have that fixed in the next build - sorry, I misread this the first
> time.
> 
> > > 
> > > New files:
> > > 
> > > spec: https://drive.google.com/open?id=0BxOz1eBnQT3nOW9XWXZwNzhEY1U
> > > srpm: https://drive.google.com/open?id=0BxOz1eBnQT3nT2FJQjlhYXVTdDA
> > 
> > '%defattr(-,root,root,-)' and 'rm -rf %{buildroot}' are used for epel5 only.
> > 
> 
> Is the %if 0%{?rhel} not sufficient around these statements?  Or should it
> just be removed all together?

If this package isn't for epel5, you can remove all.

> 
> > Why coot-1.spec ?
> > SPEC file must have same name of src-rpm.
> 
> Doh, silly google drive renaming.  I'll fix in the next upload.

Why not fedorapeople?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to