https://bugzilla.redhat.com/show_bug.cgi?id=1385180
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
into pidgin → for pidgin
%{__rm} → rm
There's absolutely no need to do this. The guidelines require macros for
*directories*, but not for executables. If you have a rogue rm in the path, you
have bigger problems, and anyway, there are various other programs called
during build, so guarding just rm isn't useful. Same for %__make.
+ package name is OK
+ latest version
+ license is acceptable for Fedora (GPLv2+)
+ license is specified correctly
+ provides/requires look OK
+ builds and installs OK
+ no scriptlets needed (.so in private directory)
- versioning doesn't follow the guidelines
[https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages has
the rules, but it's rather muddled unfortunately]. I think keeping the git date
in version makes sense, but the git tag should be moved to the release tag.
%global gitcommit ea683512f9b82f2257770f0ed56d819eea230fc2
%global gitdate 20160405
%{?gitcommit:%global gitcommitshort %(c=%{gitcommit}; echo ${c:0:7})}
Version: 0.0.%{gitdate}
Release: 1%{?gitcommit:.git%{gitcommitshort}}%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
