https://bugzilla.redhat.com/show_bug.cgi?id=1412128
--- Comment #8 from Thomas Andrejak <[email protected]> --- SPEC : https://fedorapeople.org/~totol/libpreludedb.spec SRPM : https://fedorapeople.org/~totol/libpreludedb-3.1.0-26.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > Hm, I still see %define, not %global. Please fix that up when importing. > done > > Group: System Environment/Libraries > Not necessary > [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections] > done > > Release: 26%{?dist} > Why so high? You could reset it to 1 when importing. > done > + package name is OK > + license is acceptable (GPLv2+) > + license is specified correctly > + builds and installs fine > + provides/requires/buildrequires look sane > + scriptlets are OK > + %check is present and passes > + python packaging guidelines are used > + %python_provide are present > > I think you could add > Suggests: preludedb-mysql > Suggests: preludedb-pgsql > Suggests: preludedb-sqlite3 > in the main package. done > > Package is APPROVED. Thanks for the review ! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
