https://bugzilla.redhat.com/show_bug.cgi?id=1412128
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- Hm, I still see %define, not %global. Please fix that up when importing. > Group: System Environment/Libraries Not necessary [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections] > Release: 26%{?dist} Why so high? You could reset it to 1 when importing. + package name is OK + license is acceptable (GPLv2+) + license is specified correctly + builds and installs fine + provides/requires/buildrequires look sane + scriptlets are OK + %check is present and passes + python packaging guidelines are used + %python_provide are present I think you could add Suggests: preludedb-mysql Suggests: preludedb-pgsql Suggests: preludedb-sqlite3 in the main package. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
