https://bugzilla.redhat.com/show_bug.cgi?id=1538658



--- Comment #12 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
(In reply to Brett Lentz from comment #11)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> > > %global sum Python library to load and dump configuration files in 
> > > various formats
> > Using normal Summary: and then %summary subsequently saves one line ;)
> > 
> 
> Not true. The summary is used in 3 places because of the python2 & python3
> sub-packaged. The macro saves copy/pasting the same text in 3 places.  :)

I didn't mean copying the text three times. I meant something like this:
Summary: blah blah blah
...
Summary: %summary
...
Summary: %summary

Macro %summary is automatically defined to the contents of the last Summary
line.

> > During build I see the following error:
> > >     import cbor
> > > ImportError: No module named cbor
> > Is some dependency missing?
> > 
> 
> There is support for a backend (cbor) that does not currently have a package
> in Fedora. If it's okay with you, I'd prefer to not block this package on
> the one missing backend.
> 
> This anyconfig package is a dependency of the package I'm ultimately looking
> to get into Fedora (molecule). However, anyconfig's support for cbor is not
> a part of my critical path.
> 
> I am willing to work on a python-cbor package after anyconfig is in Fedora,
> if that works for you.

Sure, whatever works. There is no obligation to package everything possible. If
something is an optional dependency, it's entirely reasonable to leave it for
later or to somebody else who actually needs it.

> > and later:
> > > toml.py:docstring of 
> > > anyconfig.backend.toml.Parser._load_from_stream_fn:6: WARNING: Definition 
> > > list ends without a blank line; unexpected unindent.
> > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/backend/xml.py:docstring
> > >  of anyconfig.backend.xml._tweak_ns:4: WARNING: Field list ends without a 
> > > blank line; unexpected unindent.
> > > /builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/docs/api/anyconfig.cli.rst:4:
> > >  WARNING: autodoc: failed to import module u'anyconfig.cli'; the 
> > > following exception was raised:
> > > Traceback (most recent call last):
> > >   File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 
> > > 658, in import_object
> > >     __import__(self.modname)
> > >   File 
> > > "/builddir/build/BUILD/python-anyconfig-RELEASE_0.9.3/anyconfig/cli.py", 
> > > line 42, in <module>
> > >     sys.stdout = codecs.getwriter(_ENCODING)(sys.stdout)
> > >   File "/usr/lib64/python2.7/codecs.py", line 1009, in getwriter
> > >     return lookup(encoding).streamwriter
> > > TypeError: lookup() argument 1 must be string, not None
> > > done
> > 
> This looks like a bug in the docs. I'll point it out to upstream.
Great.

> > And now the hard part: what is the difference in behaviour or output between
> > anyconfig-2 and anyconfig-3?
> 
> There is no difference, AFAICS.
OK. If there is no difference, then only one version of the executable should
be packed. See
https://fedoraproject.org/wiki/Packaging:Python#Executables_in_.2Fusr.2Fbin:
> If the executables provide the same functionality independent of whether they 
> are run on top of Python 2 or Python 3, then only the Python 3 version of the 
> executable should be packaged.

You went through the effort to get the symlinks right, but it now seems that
not actually necessary ;(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to