https://bugzilla.redhat.com/show_bug.cgi?id=1859207
Artur Iwicki <fed...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(fed...@svgames.pl |
|) |
--- Comment #7 from Artur Iwicki <fed...@svgames.pl> ---
[!]: Package consistently uses macros (instead of hard-coded directory names).
In %files, you have:
%dir /etc/sane.d
%config(noreplace) /etc/sane.d/airscan.conf
Use "%{_sysconfdir}" instead of hard-coding "/etc".
[!]: Latest version is packaged.
The SRPM contained the latest version at the time it was submitted,
but a few days ago a new version, 0.99.11, has been released.
[x]: Packages should try to preserve timestamps of original installed files.
The upstream Makefile does not use the "-p" flag when installing man pages.
I don't think you need to patch this, though it'd be nice to file an issue
or submit a pull request.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /etc/sane.d(sane-backends),
/etc/sane.d/dll.d(sane-backends), /usr/lib64/sane(sane-backends)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libsane-
airscan
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Rpmlint
-------
Checking: sane-airscan-0.99.10-1.fc33.x86_64.rpm
libsane-airscan-0.99.10-1.fc33.x86_64.rpm
sane-airscan-debuginfo-0.99.10-1.fc33.x86_64.rpm
sane-airscan-debugsource-0.99.10-1.fc33.x86_64.rpm
sane-airscan-0.99.10-1.fc33.src.rpm
sane-airscan.x86_64: W: spelling-error Summary(en_US) eSCL -> es Cl, encl, eccl
sane-airscan.x86_64: W: incoherent-version-in-changelog 0.99.8-1
['0.99.10-1.fc33', '0.99.10-1']
libsane-airscan.x86_64: W: spelling-error Summary(en_US) eSCL -> es Cl, encl,
eccl
libsane-airscan.x86_64: W: spelling-error %description -l en_US eSCL -> es Cl,
encl, eccl
libsane-airscan.x86_64: W: spelling-error %description -l en_US driverless ->
driver less, driver-less, riderless
sane-airscan.src: W: spelling-error Summary(en_US) eSCL -> es Cl, encl, eccl
5 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (debuginfo)
-------------------
Checking: sane-airscan-debuginfo-0.99.10-1.fc33.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
(none): E: no installed packages by name libsane-airscan
(none): E: no installed packages by name sane-airscan-debuginfo
(none): E: no installed packages by name sane-airscan-debugsource
(none): E: no installed packages by name sane-airscan
0 packages and 0 specfiles checked; 0 errors, 0 warnings.
Source checksums
----------------
https://github.com/alexpevzner/sane-airscan/archive/0.99.10/sane-airscan-0.99.10.tar.gz
:
CHECKSUM(SHA256) this package :
e32034edaf3f3d8f6a1ba99e66de9f25d60fc036931cf6ca9cc5744575d11135
CHECKSUM(SHA256) upstream package :
e32034edaf3f3d8f6a1ba99e66de9f25d60fc036931cf6ca9cc5744575d11135
Requires
--------
sane-airscan (rpmlib, GLIBC filtered):
libavahi-client.so.3()(64bit)
libavahi-common.so.3()(64bit)
libavahi-glib.so.1()(64bit)
libc.so.6()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libsane-airscan(x86-64)
libsoup-2.4.so.1()(64bit)
libxml2.so.2()(64bit)
libxml2.so.2(LIBXML2_2.4.30)(64bit)
rtld(GNU_HASH)
libsane-airscan (rpmlib, GLIBC filtered):
config(libsane-airscan)
libavahi-client.so.3()(64bit)
libavahi-common.so.3()(64bit)
libavahi-glib.so.1()(64bit)
libc.so.6()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libjpeg.so.62()(64bit)
libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit)
libjpeg.so.62(LIBJPEG_6.2)(64bit)
libm.so.6()(64bit)
libpng16.so.16()(64bit)
libpng16.so.16(PNG16_0)(64bit)
libsoup-2.4.so.1()(64bit)
libxml2.so.2()(64bit)
libxml2.so.2(LIBXML2_2.4.30)(64bit)
rtld(GNU_HASH)
sane-airscan-debuginfo (rpmlib, GLIBC filtered):
sane-airscan-debugsource (rpmlib, GLIBC filtered):
Provides
--------
sane-airscan:
sane-airscan
sane-airscan(x86-64)
libsane-airscan:
config(libsane-airscan)
libsane-airscan
libsane-airscan(x86-64)
libsane-airscan.so.1()(64bit)
sane-airscan-debuginfo:
debuginfo(build-id)
sane-airscan-debuginfo
sane-airscan-debuginfo(x86-64)
sane-airscan-debugsource:
sane-airscan-debugsource
sane-airscan-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -n /home/rpmbuilder/sane-airscan
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: PHP, fonts, Java, Ocaml, R, Haskell, Python, Perl,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
