https://bugzilla.redhat.com/show_bug.cgi?id=2181035

Fabio Valentini <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Fabio Valentini <[email protected]> ---
Two comments:

1. Please also fix the license in the Cargo.toml metadata.
Otherwise it will not be correctly taken into account by tools like the
"%cargo_license" RPM macro.

2. Please change the libc ">= 0.2.39" requirement to be either "^0.2.39" or
just "0.2.39" (the latter of which are equivalent), and submit this change
upstream. It is probably what upstream project intended, but used ">=" by
mistake or due to a misunderstanding of how cargo resolves dependencies.

Requirements like ">= 0.2.39" that are semi-open ranges are pretty dangerous
and will break at an unknown point in the future.
For example, this requirement also matches "0.3.0" or even "42.0.99", all of
which are *explicitly API-incompatible* with v0.2.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2181035
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to