https://bugzilla.redhat.com/show_bug.cgi?id=2418764
Jayaraj J <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #19 from Jayaraj J <[email protected]> --- Spec URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination.spec SRPM URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination-0.15.1-1.fc43.src.rpm Description: FastAPI Pagination provides easy, extensible pagination for FastAPI applications with support for multiple ORMs and async DB layers. Fedora Account System Username: jyrj [fedora-review-service-build] --- (In reply to Miro Hrončok from comment #18) > > I couldn't keep `%pyproject_buildrequires -x sqlalchemy` but the build > > failed because python3dist(sqlakeyset) is not currently available in Fedora. > > That is exactly the reason you tried to add it. It means you MUST not use > `%pyproject_extras_subpkg -n python3-fastapi-pagination sqlalchemy` either. > > > Keep those in sync. For example, I believe the following extras should be > packageable: ormar (no dependencies), asyncpg (needs SQLAlchemy and > asyncpg), > > %pyproject_extras_subpkg -n python3-fastapi-pagination ormar,asyncpg > ... > %pyproject_buildrequires -x ormar,asyncpg Thanks for the tip on -x, Miro! It was very helpful. it revealed a hidden dependency chain where the django extra pulls in databases, which is currently missing in Fedora (just like sqlakeyset for sqlalchemy). I have updated the spec to package only the extras that have all dependencies available (asyncpg, mongoengine, ormar). I also added detailed comments in the spec file explaining exactly which dependencies are missing for the excluded extras, so we can easily enable them in the future. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418764 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418764%23c19 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
