https://bugzilla.redhat.com/show_bug.cgi?id=2418764
Jayaraj J <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #15 from Jayaraj J <[email protected]> --- Spec URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination.spec SRPM URL: https://gitlab.com/jyrj/python-fastapi-pagination/-/raw/main/python-fastapi-pagination-0.15.1-1.fc43.src.rpm Description: FastAPI Pagination provides easy, extensible pagination for FastAPI applications with support for multiple ORMs and async DB layers. Fedora Account System Username: jyrj [fedora-review-service-build] --- (In reply to Miro Hrončok from comment #14) > > %generate_buildrequires > > # Exclude unavailable extras when generating build requirements so the > > package > > # won't break in future updates if upstream adds new dependencies to the > > sqlalchemy extra. > > %pyproject_buildrequires -x sqlalchemy > > This comment is a tad confusing. What about: > > # BuildRequire the dependencies of the packaged extras, > # so the package won't break in future updates if upstream adds new > dependencies to them. > > > However, I don't think this comment is needed. This is a standard practice. I have removed that comment. Thank you for the suggestion. I couldn't keep `%pyproject_buildrequires -x sqlalchemy` but the build failed because python3dist(sqlakeyset) is not currently available in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2418764 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418764%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
