https://bugzilla.redhat.com/show_bug.cgi?id=2418764
Miro Hrončok <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |om) | --- Comment #11 from Miro Hrončok <[email protected]> --- > We exclude the 'ext' folder Please document the WHY rather than the WHAT. In this case, e.g. "The ext module contains extensions with unavailable optional dependencies" > %pyproject_extras_subpkg -n python3-fastapi-pagination sqlalchemy A similar comment could be added here. Something like "Many other extras omitted due to unavailable dependencies." I also highly recommend using `%pyproject_buildrequires -x sqlalchemy` now, to ensure the sqlalchemy extra does not gain new unavailable dependencies when the package is updated in the future. Anyway, the spec file is looking very nice now, good job. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418764 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418764%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
