https://bugzilla.redhat.com/show_bug.cgi?id=2333620
--- Comment #17 from Peter Oliver <[email protected]> --- (In reply to Benson Muite from comment #16) > > > a) Some javascript files are under the Blue Oak license, this license > > > needs > > > to be listed > > > > AFAICT, this licence is only used for development dependencies which aren't > > bundled. > > nodejs-isexe is bundled and is under Blue Oak license: > https://www.npmjs.com/package/isexe Thanks. That was a recent addition which slipped through. I have added a check to prevent this from happening again. > b) For directory ownership, until the bug is fixed in rawhide consider > replacing > > BuildRequires: /usr/bin/node > BuildRequires: /usr/bin/perl > BuildRequires: nodejs-devel > > Requires: nodejs > > by > > BuildRequires: /usr/bin/node > BuildRequires: /usr/bin/perl > BuildRequires: nodejs22-devel > > Requires: nodejs22 I'm not sure that that would help, since it neither provides /usr/lib/node_modules nor overrides modifies the value of %{nodejs_sitelib}. > c) The files > > eask.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/eask/node_modules_prod/.package-lock.json > eask.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/eask/node_modules_prod/require-directory/.jshintrc > eask.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/eask/node_modules_prod/require-directory/.npmignore > eask.noarch: W: hidden-file-or-dir > /usr/lib/node_modules/eask/node_modules_prod/require-directory/.travis.yml > > can probably be removed Probably, but other packages contain similar files, so it feels like something that needs tackling in nodejs-packaging-bundler or the Node.js packaging guidelines, rather than in this one package. > d) Consider using dos2unix to prevent the line ending warning on: > /usr/share/doc/eask/README.md Done. SRPM URL: https://mavit.fedorapeople.org/rpm/eask-0.12.6-2.fc45.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333620 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333620%23c17 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
