https://bugzilla.redhat.com/show_bug.cgi?id=2333620
--- Comment #16 from Benson Muite <[email protected]> --- (In reply to Peter Oliver from comment #13) > (In reply to Benson Muite from comment #12) > > > - Dist tag is present. > > I believe this is a false positive. If not, could you point it out for me? This is fine. If you want to avioid rasing this, use rpmbuild -bs eask.spec to create the src.rpm file instead of fedpkg srpm > > > - Package does not contain duplicates in %files. > > Note: warning: File listed twice: > > /usr/lib/node_modules/eask/node_modules_prod/cliui/LICENSE.txt > > I think the cure might be worse than the disease, here, but okay. > > SRPM URL: https://mavit.fedorapeople.org/rpm/eask-0.12.4-3.fc45.src.rpm > Thanks for the cleanup. Was not going to insist on this. > > Note: License file license.js is not marked as %license > > It's not a licence file. > > > [!]: License field in the package spec file matches the actual license. > > Note: Checking patched sources after %prep for licenses. Licenses > > found: > > ... > > "*No copyright* GNU General Public License, Version 3", > > I think this is caused by a typo in package.json. I have raised it upstream > at https://github.com/emacs-eask/cli/pull/396 > > > "*No copyright* Academic Free License v3.0 and/or Apache License 2.0", > > This is a false positive caused by lisp/lint/license.el, which contains the > names of many licences because its purpose is to scan Emacs packages for > them. > Ok. > > a) Some javascript files are under the Blue Oak license, this license needs > > to be listed > > AFAICT, this licence is only used for development dependencies which aren't > bundled. nodejs-isexe is bundled and is under Blue Oak license: https://www.npmjs.com/package/isexe b) For directory ownership, until the bug is fixed in rawhide consider replacing BuildRequires: /usr/bin/node BuildRequires: /usr/bin/perl BuildRequires: nodejs-devel Requires: nodejs by BuildRequires: /usr/bin/node BuildRequires: /usr/bin/perl BuildRequires: nodejs22-devel Requires: nodejs22 c) The files eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/.package-lock.json eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.jshintrc eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.npmignore eask.noarch: W: hidden-file-or-dir /usr/lib/node_modules/eask/node_modules_prod/require-directory/.travis.yml can probably be removed d) Consider using dos2unix to prevent the line ending warning on: /usr/share/doc/eask/README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2333620 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333620%23c16 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
