https://bugzilla.redhat.com/show_bug.cgi?id=2333620
--- Comment #7 from Peter Oliver <[email protected]> --- Thanks for the review. The issue regarding LICENSE.txt seems reasonable to me, even though it is not addressed by the guidelines for bundled Node.js packages (https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_bundled_licenses). I have updated the spec and SRPM to address this. Copr lightly mangles the .spec file it includes in its SRPM. This is harmless. Nevertheless, here is an unmangled copy of the SRPM: SRPM URL: https://mavit.fedorapeople.org/rpm/eask-0.12.4-2.fc45.src.rpm "Dist tag is present" appears incorrect to me. I think fedora-review is confused by %{autorelease} (or perhaps by Copr's expansion of %{autorelease} in the SRPM). Rpmlint detects an outdated address for the Free Software Foundation in some files. I have sent a patch upstream (https://github.com/emacs-eask/cli/pull/390). The missing directory /usr/lib/node_modules doesn't occur on Fedora 42 or 43, so I assume is somehow related to https://fedoraproject.org/wiki/Changes/NodejsAlternativesSystem. I have asked the Node.js SIG about this: https://lists.fedoraproject.org/archives/list/[email protected]/thread/PCCOHMTV2UYKNWCBO4IJWNFSDDBU3QGK/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2333620 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202333620%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
